Skip to content
This repository has been archived by the owner on Jul 5, 2023. It is now read-only.

Use PyUnicode_DecodeUnicodeEscape directly #172

Closed
wants to merge 1 commit into from

Conversation

srittau
Copy link
Collaborator

@srittau srittau commented Nov 10, 2021

No description provided.

@hauntsaninja
Copy link
Collaborator

hauntsaninja commented Nov 10, 2021

Thanks! In general, I think typed-ast tries to avoid changes to the original source. See my comment on #171 (comment) , I think this only results in different, but slightly more consistent behaviour across Python versions in a situation in which probably no one will ever use typed-ast (and in which typed-ast is already inconsistent across Python versions). So not sure whether this is worth it.

@hauntsaninja
Copy link
Collaborator

Let me know what you think and then I'll make a release accordingly.

@srittau
Copy link
Collaborator Author

srittau commented Nov 10, 2021

By now, I don't think we need to stay close to the original code, since that is dead anyway. I believe that this change could avoid problems when _PyUnicode_DecodeUnicodeEscape is defined by Python (as it obviously was prior to the latest 3.9 release).

@srittau srittau closed this Mar 24, 2022
@srittau srittau deleted the decode-unicode branch March 24, 2022 21:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants