Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problem with monospace rendering in Vivaldi #104

Merged
merged 1 commit into from Feb 6, 2023

Conversation

ZedThree
Copy link
Contributor

Fixes #98

@cpython-cla-bot
Copy link

cpython-cla-bot bot commented Jan 30, 2023

All commit authors signed the Contributor License Agreement.
CLA signed

Copy link
Member

@ezio-melotti ezio-melotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What browsers have you tested this with?
Do we know why the quoted `"monospace" was included and should we keep it somewhere in the list?

@hugovk
Copy link
Member

hugovk commented Jan 31, 2023

Quoted "monospace" was added in #85 to workaround a Chrome bug, which was fixed in Chrome 96 (Nov 2021): python/pythondotorg#1708 (comment).

By now, there's very little usage of Chrome 96 and older versions. Chrome 96% is 0.04% at https://caniuse.com/usage-table, and it's something like 1.68% for 96 and older.

(It would be good if we could hook up PR previews on Read the Docs or Netlify, that would make testing easier.)

@ZedThree
Copy link
Contributor Author

I tested with Vivaldi 5.6.2867.62 and Firefox 109.0

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested building CPython docs locally using:

diff --git a/Doc/requirements.txt b/Doc/requirements.txt
index 134f39d6d7..c6d9c6a663 100644
--- a/Doc/requirements.txt
+++ b/Doc/requirements.txt
@@ -12,4 +12,4 @@ sphinxext-opengraph>=0.7.1
 
 # The theme used by the documentation is stored separately, so we need
 # to install that as well.
-python-docs-theme>=2022.1
+git+https://github.com/ZedThree/python-docs-theme@fix-monospace-vivaldi#egg=python-docs-theme

Looks fine on macOS Ventura 13.1 and Chrome 108:

image

And Safari 16.2:

image

And Firefox 109:

image

And Opera 93:

image

@hugovk
Copy link
Member

hugovk commented Jan 31, 2023

And I've put a preview build up at https://hugovk-cpython.readthedocs.io/en/python-docs-theme-pr-104/ if anyone else wants to test it.

Looks fine with Chrome 109 on Samsung S10 with Android 12.

@hugovk hugovk merged commit f769cf3 into python:main Feb 6, 2023
@hugovk
Copy link
Member

hugovk commented Feb 6, 2023

Thank you!

@ZedThree ZedThree deleted the fix-monospace-vivaldi branch February 6, 2023 09:37
@hugovk hugovk mentioned this pull request Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Weird monospace bug
3 participants