Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add disable/enable error code opt to config_types #9537

Closed
wants to merge 1 commit into from
Closed

Add disable/enable error code opt to config_types #9537

wants to merge 1 commit into from

Conversation

amikrop
Copy link
Contributor

@amikrop amikrop commented Oct 5, 2020 •
edited

The disable_error_code and enable_error_code config file options were being cast to list, as they were not
included in the config_types dict in config_parser.py.

hauntsaninja
hauntsaninja reviewed Oct 5, 2020
View reviewed changes
Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks for reporting and fixing! If you wanted to add a test, test-data/unit/check-flags.test would be the place to do it

@amikrop amikrop mentioned this pull request Oct 5, 2020
Closed
@amikrop
Copy link
Contributor Author

amikrop commented Oct 5, 2020 •
edited

Tried this #9538 without being sure of the exact format of the test case fixtures, though.

@hauntsaninja
Copy link
Collaborator

Closing in favour of #9538 then :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hauntsaninja hauntsaninja hauntsaninja left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@amikrop @hauntsaninja