Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix partial type crash during protocol checking #9495

Merged
merged 3 commits into from Sep 29, 2020
Merged

Fix partial type crash during protocol checking #9495

merged 3 commits into from Sep 29, 2020

Commits on Sep 28, 2020

  1. Fix partial type crash during protocol checking 

    In particular, this affected hashables.
    hauntsaninja committed Sep 28, 2020
    Copy the full SHA
    bfc78e7 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2020

  1. add tests

    hauntsaninja committed Sep 29, 2020
    Copy the full SHA
    43d5872 View commit details
    Browse the repository at this point in the history

  2. Fix up testPartialTypeProtocolHashable 

    This test case was meant to use `--no-strict-optional`, not
`--strict-optional`, but happened to crash anyway because object in the
test stubs doesn't have __hash__. Both changes made.
    hauntsaninja committed Sep 29, 2020
    Copy the full SHA
    85e301e View commit details
    Browse the repository at this point in the history