Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stubtest: fix false negative with dunder methods, small changes #8886

Merged
merged 4 commits into from May 26, 2020
Merged

stubtest: fix false negative with dunder methods, small changes #8886

merged 4 commits into from May 26, 2020

Commits on May 26, 2020

  1. stubtest: use stub.name over runtime.__name__ 

    Seems to be a little more reliable
    hauntsaninja committed May 26, 2020
    Copy the full SHA
    d0f10e7 View commit details
    Browse the repository at this point in the history

  2. stubtest: remove unnecessary code 

    I can no longer repro any of the behaviour related to distutils.command.
I found one case it can come up involving builtins, but overall I think
this code is just simpler like this.
    hauntsaninja committed May 26, 2020
    Copy the full SHA
    58e596a View commit details
    Browse the repository at this point in the history

  3. stubtest: fix false negatives 

    If the stub doesn't list dunder methods, we wouldn't check them earlier.
There are a lot of false negatives due to this.
    hauntsaninja committed May 26, 2020
    Copy the full SHA
    573ac89 View commit details
    Browse the repository at this point in the history

  4. teststubtest: add a test for the previous commit 

    Also covers some of the MRO logic in verify_typeinfo
    hauntsaninja committed May 26, 2020
    Copy the full SHA
    c44e00a View commit details
    Browse the repository at this point in the history