Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine testcase and variable usage for "produce error when assigning NamedTuple to attribute" #8112

Merged
merged 1 commit into from
Dec 9, 2019
Merged

Refine testcase and variable usage for "produce error when assigning NamedTuple to attribute" #8112

merged 1 commit into from
Dec 9, 2019

Conversation

TH3CHARLie
Copy link
Collaborator

Followed the discussion in #8107 (comment), refine the code merged in #7662 by:

  • move testcase from pythoneval.test to check-namedtuple.test and rename it from testNamedTupleAtRunTime to testAssignNamedTupleAsAttribute
  • change s.lvalues[0] to lvalue to make it more concise

@TH3CHARLie TH3CHARLie closed this Dec 9, 2019
@TH3CHARLie TH3CHARLie reopened this Dec 9, 2019
@TH3CHARLie
Copy link
Collaborator Author

Reopen to trigger travis-CI rebuild, previous build failed at runtime test suite on OSX with abnormal errors

ilevkivskyi
ilevkivskyi approved these changes Dec 9, 2019
View reviewed changes
Copy link
Member

@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clean-up!

@ilevkivskyi ilevkivskyi merged commit ce0703a into python:master Dec 9, 2019
@TH3CHARLie TH3CHARLie deleted the refine-7662 branch December 9, 2019 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilevkivskyi ilevkivskyi ilevkivskyi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TH3CHARLie @ilevkivskyi