Make reported line and column numbers more precise #7578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilevkivskyi
approved these changes
Sep 27, 2019
test-data/unit/check-columns.test
Outdated
| if int(): | ||
| x = 0 # type: x y | ||
| [out] | ||
| main:2:9: error: syntax error in type comment 'x y' |
There was a problem hiding this comment.
It is not clear what is 9th column here? Maybe keep the intent as 4, otherwise there are two 8-column offsets, the indent itself and also the length of # type: .
There was a problem hiding this comment.
A good point, updated.
| @@ -133,9 +133,11 @@ def foobar(): pass | |||
|
|
|||
| [builtins fixtures/module.pyi] | |||
|
|
|||
| [case testColumnUnexpectedKeywordArg] | |||
| [case testColumnUnexpectedOrMissingKeywordArg] | |||
| def f(): pass | |||
| (f(x=1)) # E:2: Unexpected keyword argument "x" for "f" | |||
There was a problem hiding this comment.
In future we might want to point to x here.
There was a problem hiding this comment.
Yeah, added a TODO. I don't think that we can easily find the location of x currently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most notably, report more precise error locations for incompatible
return value types and incompatible default argument values.
Also add some tests.
Work towards #7053.