Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't serialize redefined symbol nodes #7499

Merged
merged 1 commit into from Sep 12, 2019
Merged

Don't serialize redefined symbol nodes #7499

merged 1 commit into from Sep 12, 2019

Commits on Sep 11, 2019

  1. Don't serialize redefined symbol nodes

    Redefined nodes sometimes have busted internal references (like a self
    argument that has the class as its type even though it won't be able
    to look it up) which can cause crashes. Since they can't have
    references from outside themselves, we don't lose anything by not
    serializing them.
    
    Fixes a crash I observed at Dropbox.
    
    This partially reverts #7413, which introduced this crash (while
    fixing another), but leaves the test case it added.
    msullivan committed Sep 11, 2019
    Copy the full SHA
    abd9476 View commit details
    Browse the repository at this point in the history