Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Point error to incompatible argument instead of call expression #7470

Merged
merged 14 commits into from Sep 10, 2019
Merged

Point error to incompatible argument instead of call expression #7470

merged 14 commits into from Sep 10, 2019

Commits on Sep 4, 2019

  1. Point error message to incompatible argument expression 

    Previously we just pointed to the beginning of the call expression,
which is not great if there are multiple arguments.

Also point to incompatible list/dict/set item instead of the beginning
of a list/dict/set expression.

Note that this may require some `# type: ignore` comments to be
updated.
    @JukkaL
    JukkaL committed Sep 4, 2019
    Copy the full SHA
    83d09fd View commit details
    Browse the repository at this point in the history

  2. Turn off column numbers by default

    @JukkaL
    JukkaL committed Sep 4, 2019
    Copy the full SHA
    4db0af3 View commit details
    Browse the repository at this point in the history

  3. Fix issues

    @JukkaL
    JukkaL committed Sep 4, 2019
    Copy the full SHA
    ade34e2 View commit details
    Browse the repository at this point in the history

  4. Fix line/column of slice expressions

    @JukkaL
    JukkaL committed Sep 4, 2019
    Copy the full SHA
    aeb8f2b View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2019

  1. Fix various issues with wrong lines/columns; fix tests

    @JukkaL
    JukkaL committed Sep 5, 2019
    Copy the full SHA
    00fc08a View commit details
    Browse the repository at this point in the history

  2. Fix various tests

    @JukkaL
    JukkaL committed Sep 5, 2019
    Copy the full SHA
    3261540 View commit details
    Browse the repository at this point in the history

  3. Update test case

    @JukkaL
    JukkaL committed Sep 5, 2019
    Copy the full SHA
    80f5fe7 View commit details
    Browse the repository at this point in the history

  4. Add test case

    @JukkaL
    JukkaL committed Sep 5, 2019
    Copy the full SHA
    e1eb7e2 View commit details
    Browse the repository at this point in the history

  5. Fix test case

    @JukkaL
    JukkaL committed Sep 5, 2019
    Copy the full SHA
    a193558 View commit details
    Browse the repository at this point in the history

  6. Fix slices

    @JukkaL
    JukkaL committed Sep 5, 2019
    Copy the full SHA
    03aad6e View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' into columns-3-arg

    @JukkaL
    JukkaL committed Sep 5, 2019
    Copy the full SHA
    837bb9e View commit details
    Browse the repository at this point in the history

  8. Update test case

    @JukkaL
    JukkaL committed Sep 5, 2019
    Copy the full SHA
    629ab4d View commit details
    Browse the repository at this point in the history

  9. Address review

    @JukkaL
    JukkaL committed Sep 5, 2019
    Copy the full SHA
    fbd4dfc View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2019

  1. Fix tests on Python 3.8

    @JukkaL
    JukkaL committed Sep 6, 2019
    Copy the full SHA
    49128f1 View commit details
    Browse the repository at this point in the history