Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore flake8 warnings about assert False #6602

Merged
merged 2 commits into from Mar 29, 2019
Merged

Ignore flake8 warnings about assert False #6602

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d7fc4ee
Ignore flake8 warnings about assert False
msullivan Mar 28, 2019
4a0b51b
Ignore more
msullivan Mar 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion setup.cfg
View file
Open in desktop
Expand Up @@ -41,7 +41,8 @@ exclude =
# B3??: Python 3 compatibility warnings
# B006: use of mutable defaults in function signatures
# B007: Loop control variable not used within the loop body.
ignore = E251,E128,F401,W601,E701,W503,W504,E704,E402,B3,B006,B007
# B011: Don't use assert False
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does flake8 want you to use???

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not call assert False since python -O removes these calls. Instead callers should raise AssertionError().

ignore = E251,E128,F401,W601,E701,W503,W504,E704,E402,B3,B006,B007,B011

[coverage:run]
branch = true
Expand Down