Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow type ignores after type comments #6591

Merged
merged 4 commits into from Mar 27, 2019
Merged

Allow type ignores after type comments #6591

merged 4 commits into from Mar 27, 2019

Commits on Mar 26, 2019

  1. Allow type ignores after type comments 

    This is a bit of a hack in fastparse, but allows for the following to pass typechecking:

`x = 1  # type: str  # type: ignore`

Fixes python#5967
    @ethanhs
    ethanhs committed Mar 26, 2019
    Copy the full SHA
    038b122 View commit details
    Browse the repository at this point in the history

  2. Don't pick up type ignores in comments

    @ethanhs
    ethanhs committed Mar 26, 2019
    Copy the full SHA
    223de15 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2019

  1. Merge branch 'master' of github.com:python/mypy into ignoretypecomment

    @ethanhs
    ethanhs committed Mar 27, 2019
    Copy the full SHA
    5c8d5cf View commit details
    Browse the repository at this point in the history

  2. Use better regex to recognize extra type ignore, fix indents

    @ethanhs
    ethanhs committed Mar 27, 2019
    Copy the full SHA
    d0cf678 View commit details
    Browse the repository at this point in the history