check type of module_all earlier #5789
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Instead it might be better to convert the |
ilevkivskyi
reviewed
Oct 15, 2018
| module_all is None or | ||
| (isinstance(module_all, list) and all(isinstance(v, str) for v in module_all)) | ||
| ): | ||
| raise CantImport(module) |
There was a problem hiding this comment.
This error might be confusing, because we were able to import the module, but it contains a critical error. Maybe add a message (explaining cause) to this exception class?
| if not ( | ||
| module_all is None or | ||
| (isinstance(module_all, list) and all(isinstance(v, str) for v in module_all)) | ||
| ): |
There was a problem hiding this comment.
This statement is a bit hard to read, I think it would be easier if you reformulate it as if module_all is not None and <bad __all__...>.
msullivan
requested changes
Dec 20, 2018
|
I'm going to close this. Feel free to reopen if you pick it back up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently mypy.stubgen crashes when processing
aiofiles/__init__.py, because__all__isTuple[Callable[..., object]]and doesn't continue to process any further modulesSee Tinche/aiofiles#53 for the upstream fix