fix: TypeGuard becomes bool instead of Any when passed as TypeVar (fixes #17117) #17145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sloboegen
commented
Apr 20, 2024
mypy/constraints.py
Outdated
Comment on lines
1021
to
1023
| bool_type = UnionType( | ||
| [LiteralType(True, cactual_ret_type), LiteralType(False, cactual_ret_type)] # type: ignore[arg-type] | ||
| ) |
There was a problem hiding this comment.
It seems ugly, but I can't find another way to create Instance of builtins.bool. It also leads to the CI failure :(
Oh, I got that we can use just cactual_ret_type without rewriting it...
sloboegen
commented
Apr 20, 2024
Comment on lines
1028
to
1029
| elif template.type_guard is not None: | ||
| template_ret_type = AnyType(TypeOfAny.special_form) |
There was a problem hiding this comment.
Does this branch make sense?
When we use TypeGuard or TypeIs in template it seems that we should use TypeGuard/TypeIs in actual too. Otherwise, we get Never type in the previous steps. Is it true? I'm a little confused here...
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17117.