Fix type aliases with fixed-length tuples #14184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Diff from mypy_primer, showing the effect of this PR on open source code: artigraph (https://github.com/artigraph/artigraph)
+ tests/arti/types/test_python_adapters.py:188: error: Unused "type: ignore" comment
+ tests/arti/internal/test_models.py:183: error: Unused "type: ignore" comment
+ tests/arti/internal/test_models.py:192: error: Unused "type: ignore" comment
|
ilevkivskyi
approved these changes
Nov 25, 2022
sobolevn
approved these changes
Nov 25, 2022
|
I just ran into this (#11098) issue in one of my code bases today. I go to github to see whether it's been reported before, and whether it is being worked on. What am I greeted by?
and then...
I absolutely love you guys. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix type aliases like these:
Type applications involving fixed-length tuples still don't fully work. The inferred type is a variable-length tuple when constructing a tuple using a type application, e.g.
tuple[int, str]((1, "")). This seems a pretty low-priority issue, whereas the type alias use case seems common.Most of the work was by @sobolevn originally in #12134. I just finished it up.
Fixes #11098.