Add intenal flag for per-line type checking peformance #14173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JukkaL
reviewed
Nov 23, 2022
This comment has been minimized.
This comment has been minimized.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
JukkaL
approved these changes
Nov 23, 2022
There was a problem hiding this comment.
This looks very useful! I tried it out and the results look good. A few ideas about how to make this even more useful (no need to do these now):
- Generating JSON could make it a little easier to analyze the data. Analyzing the data requires some scripting, and JSON would save a few lines of code.
- Providing a tool that would analyze the data and print out some derived stats (e.g. the most expensive lines) could be helpful. This could be a script in
misc/, for example.
|
Yes, I think a tool would be helpful, I will add it later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help with the investigation of tricky performance regressions like #13821.
I tried to implement in such a way that it will give minimal impact when not used (since I am touching a hot method).