Merge subtype visitors #13303
Merge subtype visitors #13303
Conversation
This comment has been minimized.
This comment has been minimized.
|
The |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@hauntsaninja @JelleZijlstra could one of you (or both) please take a look at this? |
|
The starlette error (https://github.com/encode/starlette/blob/0b5b9c45ed281135f5d23d45041a12824d232260/starlette/config.py#L77) seems correct: the last overload is covered by the previous one. |
|
Thanks for review! Note I now also make it impossible to call |
This comment has been minimized.
This comment has been minimized.
|
Diff from mypy_primer, showing the effect of this PR on open source code: starlette (https://github.com/encode/starlette)
+ starlette/config.py:87: error: Overloaded function signature 5 will never be matched: signature 4's parameter type(s) are the same or broader [misc]
pandas (https://github.com/pandas-dev/pandas)
+ pandas/core/apply.py:510: error: Key expression in dictionary comprehension has incompatible type "Hashable"; expected type "NDFrame" [misc]
+ pandas/core/generic.py:4411: error: Missing return statement [return]
|
|
This PR has actually caused new errors on 3.11's typeshed which seem incorrect to me. Again to do with You can repro with |
|
Should be fixed by #13461 |
Avoid the use of a nested function, which are a bit slow when compiled with mypyc. Also avoid a callable value and instead call a function directly, which allows using faster native calls. Based on a quick experiment, this speeds up self check by about 3%. This addresses some of the slowdown introduced in #13303.
Mypyc isn't good at compiling nested functions, and this one was in one of the hottest code paths in all of mypy. The nested function wasn't even used all the time, but mypyc will still construct a closure object every time. This adds some code duplication, but it's well worth it. Amazingly, this speeds up self-check by about 10%! This addresses some of the slowdown introduced in #13303. #14324 addresses another related slowdown.
Avoid the use of a nested function, which are a bit slow when compiled with mypyc. Also avoid a callable value and instead call a function directly, which allows using faster native calls. Based on a quick experiment, this speeds up self check by about 3%. This addresses some of the slowdown introduced in #13303.
Mypyc isn't good at compiling nested functions, and this one was in one of the hottest code paths in all of mypy. The nested function wasn't even used that often, but mypyc would still construct a closure object every time. This adds some code duplication, but it's well worth it. Amazingly, this speeds up self-check by about 10%, if my measurements are to be trusted! This addresses some of the slowdown introduced in #13303. #14324 addresses another related slowdown.
Fixes #3297
This removes a significant chunk of code duplication. This is not a pure refactor, there were some cases when one of the visitors (mostly non-proper one) was more correct and/or complete. In few corner cases, where it was hard to decide, I merged behavior with
ifchecks.cc @JukkaL