Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stubtest: ignore more dunder pos-only errors #12294

Merged
merged 1 commit into from Mar 5, 2022
Merged

stubtest: ignore more dunder pos-only errors #12294

merged 1 commit into from Mar 5, 2022

Commits on Mar 5, 2022

  1. stubtest: ignore more dunder positional-only errors 

    This isn't actually a reversion. This logic was asymmetrical for reasons
lost to time. Although I suspect it was this way because it introduced
only a few errors on typeshed.

What changed was that as a result of python#12203 we actually started checking
a lot more dunder methods. Previously, we only checked dunders if either:
a) it was a special dunder, like __init__ or __call, or
b) the dunder was defined on the actual stub class itself

In particular, we started checking every dunder redefined at runtime
that the stub just inherited from object.

A possible intermediate option would be to not check positional-only
arguments in the case where a stub inherits the definition. I'll
experiment with that once typeshed CI is green.
    hauntsaninja committed Mar 5, 2022
    Copy the full SHA
    ec802be View commit details
    Browse the repository at this point in the history