Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash on ErasedType and covers_at_runtime #11924

Merged
merged 5 commits into from Jan 7, 2022
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions mypy/erasetype.py
Expand Up @@ -41,8 +41,7 @@ def visit_uninhabited_type(self, t: UninhabitedType) -> ProperType:
return t

def visit_erased_type(self, t: ErasedType) -> ProperType:
# Should not get here.
raise RuntimeError()
return t

def visit_partial_type(self, t: PartialType) -> ProperType:
# Should not get here.
Expand Down
1 change: 1 addition & 0 deletions mypy/subtypes.py
Expand Up @@ -1167,6 +1167,7 @@ def restrict_subtype_away(t: Type, s: Type, *, ignore_promotions: bool = False)
def covers_at_runtime(item: Type, supertype: Type, ignore_promotions: bool) -> bool:
"""Will isinstance(item, supertype) always return True at runtime?"""
item = get_proper_type(item)
supertype = get_proper_type(supertype)

# Since runtime type checks will ignore type arguments, erase the types.
supertype = erase_type(supertype)
Expand Down
21 changes: 21 additions & 0 deletions test-data/unit/check-inference.test
Expand Up @@ -3211,6 +3211,27 @@ def test(seq: List[Union[Iterable, Any]]) -> None:
reveal_type(k) # N: Revealed type is "builtins.list[Any]"
[builtins fixtures/list.pyi]

[case testErasedTypeRuntimeCoverage]
# https://github.com/python/mypy/issues/11913
from typing import TypeVar, Type, Generic, Callable, Iterable

_S = TypeVar('_S')
_T1 = TypeVar('_T1')

class map(Generic[_S]):
def __init__(self, __func: Callable[[_T1], _S], __iter1: Iterable[_T1]) -> None: ...

class DataType: ...
T = TypeVar("T", bound=DataType)

def collection_from_dict_value(model: Type[T]) -> None:
map(
# This line was failing:
lambda i: i if isinstance(i, model) else i,
["asdf"]
)
sobolevn marked this conversation as resolved.
Show resolved Hide resolved
[builtins fixtures/isinstancelist.pyi]

[case testRegression11705_Strict]
# flags: --strict-optional
# See: https://github.com/python/mypy/issues/11705
Expand Down