Skip compiling mypyc/__main__.py #11862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 29, 2021
|
Thanks, updated to add a comment |
JukkaL
pushed a commit
that referenced
this pull request
Jan 5, 2022
Fixes mypyc/mypyc#912 Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
tushar-deepsource
pushed a commit
to DeepSourceCorp/mypy
that referenced
this pull request
Jan 20, 2022
Fixes mypyc/mypyc#912 Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Skip compiling
mypyc/__main__.pyto fix mypyc/mypyc#912Test Plan
With this patch, the tests
testCompileMypycandtestErrorOutputpass during the building of the mypy 0.930 binary packages for Debian.As for CI testing, in Debian we don't build via
python3 setup.py --use-mypyc build_ext --inplacewe useMYPY_USE_MYPYC=1 python3 setup.py buildand then copy the results into a temporary directory, where we then run the tests.