Use __truediv__ for python2 with __future__ import, refs #11740
#11787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JukkaL
reviewed
Feb 22, 2022
mypy/semanal.py
Outdated
| @@ -219,7 +219,7 @@ class SemanticAnalyzer(NodeVisitor[None], | |||
| errors: Errors # Keeps track of generated errors | |||
| plugin: Plugin # Mypy plugin for special casing of library features | |||
| statement: Optional[Statement] = None # Statement/definition being analyzed | |||
| future_import_flags: Set[str] | |||
| future_import_flags: Dict[str, Set[str]] # Module name / future imports | |||
There was a problem hiding this comment.
Could these be stored in MypyFile instead, to avoid two dictionaries keyed with a module name (see modules above)?
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now
__future__imports do not leak insemanal.py.Closes #11740
Refs #11741
Refs #11276
Refs #11700