Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to generic builtin types #10766

Merged
merged 4 commits into from Jul 5, 2021
Merged

Fixes to generic builtin types #10766

merged 4 commits into from Jul 5, 2021

Conversation

JukkaL
Copy link
Collaborator

@JukkaL JukkaL commented Jul 5, 2021

This fixes these issues:

  • Allow variable-length tuple (tuple[int, ...]) in type aliases
  • Allow generic built-in types (e.g. list[int]) in stubs in all Python versions

Fixes #9980. Fixes #10303. Fixes #10731.

@github-actions

This comment has been minimized.

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2021

Diff from mypy_primer, showing the effect of this PR on open source code:

pandas (https://github.com/pandas-dev/pandas.git)
- pandas/_libs/window/aggregations.pyi:73: error: Unexpected "..."  [misc]

@JukkaL JukkaL merged commit 6eafc5e into master Jul 5, 2021
@JukkaL JukkaL deleted the fix-tuple-type-alias branch July 5, 2021 13:52
@hauntsaninja
Copy link
Collaborator

Hooray!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants