Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't ask to install a stub package if stubs are installed #10670

Merged
merged 3 commits into from Jun 22, 2021
Merged

Don't ask to install a stub package if stubs are installed #10670

merged 3 commits into from Jun 22, 2021

Commits on Jun 18, 2021

  1. Don't ask to install a stub package if stubs are installed 

    If we encounter an import of a submodule of a package with installed
stubs, and the submodule doesn't exist, don't ask to install stubs
since that's not going to help. Also make it possible to ignore this
error using `--ignore-missing-imports`.

Work on #10645.
    @JukkaL
    JukkaL committed Jun 18, 2021
    Copy the full SHA
    c09719c View commit details
    Browse the repository at this point in the history

  2. Add tests

    @JukkaL
    JukkaL committed Jun 18, 2021
    Copy the full SHA
    863aa51 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2021

  1. This doesn't work for google.protobuf, so skip the new logic

    @JukkaL
    JukkaL committed Jun 21, 2021
    Copy the full SHA
    ce702c6 View commit details
    Browse the repository at this point in the history