Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolves #10542 Add fullname of node that is still a PlaceholderNode when assertion fails #10565

Merged
merged 3 commits into from May 31, 2021
Merged

Resolves #10542 Add fullname of node that is still a PlaceholderNode when assertion fails #10565

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c491593
Resolves #10542 Add fullname of node that is still a PlaceholderNode …
TheCleric May 31, 2021
ea0f632
Update mypy/nodes.py
hauntsaninja May 31, 2021
42622c0
satisfy flake8
May 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion mypy/nodes.py
View file
Open in desktop
Expand Up @@ -3080,7 +3080,7 @@ def serialize(self, prefix: str, name: str) -> JsonDict:
and fullname != prefix + '.' + name
and not (isinstance(self.node, Var)
and self.node.from_module_getattr)):
assert not isinstance(self.node, PlaceholderNode)
assert not isinstance(self.node, PlaceholderNode), 'Definition of {} is unexpectedly incomplete'.format(fullname)
data['cross_ref'] = fullname
return data
data['node'] = self.node.serialize()
Expand Down