stubtest: fix false negative with dunder methods, small changes #8886
+37
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Appveyor CI failure isn't real. Looks like we may have disabled the Appveyor project but we still try to trigger it. Out of curiosity, what are the noisy results from enabling this for other dunders? |
|
I wasn't too thorough, but there were a number of complaints about |
added 4 commits
May 26, 2020 11:36
Seems to be a little more reliable
I can no longer repro any of the behaviour related to distutils.command. I found one case it can come up involving builtins, but overall I think this code is just simpler like this.
If the stub doesn't list dunder methods, we wouldn't check them earlier. There are a lot of false negatives due to this.
Also covers some of the MRO logic in verify_typeinfo
hauntsaninja
force-pushed
the
stubtestfixes
branch
from
c2279e3 to
c44e00a
Compare
|
#8786 just got merged, so let's try CI again |
|
cc @JelleZijlstra not sure how to request review, but everything is green now |
hauntsaninja
pushed a commit
to hauntsaninja/typeshed
that referenced
this pull request
May 26, 2020
hauntsaninja
pushed a commit
to hauntsaninja/typeshed
that referenced
this pull request
May 26, 2020
srittau
pushed a commit
to python/typeshed
that referenced
this pull request
May 27, 2020
vishalkuo
pushed a commit
to vishalkuo/typeshed
that referenced
this pull request
Jun 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a stub was completely missing a dunder method, we wouldn't check it against the runtime. It's noisy to check all dunder methods, but checking init, new and call catches a lot of false negatives on typeshed without much noise.