Produce error when assigning Enum or TypedDict as attribute #8107

TH3CHARLie · 2019-12-08T14:08:15Z

resolves #8009, simply following solution by #7662

Additionally, when I was finishing the first version of the PR I noticed that some of #7662 could be refined:

Lines 2152 to 2154 in e8ae122

    
           if isinstance(s.lvalues[0], MemberExpr): 
        
               self.fail("NamedTuple type as an attribute is not supported", lvalue) 
        
               return False

Here using lvalue instead of s.lvalues[0] would be more concise.

mypy/test-data/unit/pythoneval.test

Lines 1482 to 1492 in e8ae122

    
           [case testNamedTupleAtRunTime] 
        
           from typing import NamedTuple 
        
           class A: 
        
               def __init__(self) -> None: 
        
                   self.b = NamedTuple('x', [('s', str), ('n', int)]) 
        
           reveal_type(A().b) 
        
           [out] 
        
           _testNamedTupleAtRunTime.py:5: error: NamedTuple type as an attribute is not supported 
        
           _testNamedTupleAtRunTime.py:7: note: Revealed type is 'Any'

The test is in pythoneval.test, but it makes more sense in check-namedtuple.test and the name could be also changed accordingly.

@ilevkivskyi What's your opinion on this? Should these changes be made? And if so, should they be made in this PR or a sperate one.

ilevkivskyi · 2019-12-08T22:55:58Z

Should these changes be made? And if so, should they be made in this PR or a sperate one.

Yes, I think in a separate PR.

…me for variable (#8112) Followed the discussion in #8107 (comment), refine the code merged in #7662 by: - move testcase from `pythoneval.test` to `check-namedtuple.test` and rename it from `testNamedTupleAtRunTime` to `testAssignNamedTupleAsAttribute` - change `s.lvalues[0]` to `lvalue` to make it more concise

msullivan

This seems reasonable. Thanks!

produce error when assigning Enum or TypedDict as attribute

1cd69b5

TH3CHARLie mentioned this pull request Dec 9, 2019

Refine testcase and variable usage for "produce error when assigning NamedTuple to attribute" #8112

Merged

TH3CHARLie mentioned this pull request Dec 10, 2019

Release 0.760 planning #8115

Closed

msullivan approved these changes Dec 12, 2019

View reviewed changes

msullivan merged commit a2ab97b into python:master Dec 12, 2019

TH3CHARLie deleted the error-when-enum-or-typeddict-as-attr branch December 12, 2019 02:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Produce error when assigning Enum or TypedDict as attribute #8107

Produce error when assigning Enum or TypedDict as attribute #8107

TH3CHARLie commented Dec 8, 2019 •

edited

ilevkivskyi commented Dec 8, 2019

msullivan left a comment

	if isinstance(s.lvalues[0], MemberExpr):
	self.fail("NamedTuple type as an attribute is not supported", lvalue)
	return False

	[case testNamedTupleAtRunTime]
	from typing import NamedTuple

	class A:
	def __init__(self) -> None:
	self.b = NamedTuple('x', [('s', str), ('n', int)])

	reveal_type(A().b)
	[out]
	_testNamedTupleAtRunTime.py:5: error: NamedTuple type as an attribute is not supported
	_testNamedTupleAtRunTime.py:7: note: Revealed type is 'Any'

Produce error when assigning Enum or TypedDict as attribute #8107

Produce error when assigning Enum or TypedDict as attribute #8107

Conversation

TH3CHARLie commented Dec 8, 2019 • edited

ilevkivskyi commented Dec 8, 2019

msullivan left a comment

Choose a reason for hiding this comment

TH3CHARLie commented Dec 8, 2019 •

edited