Store the type for assignment expr (walrus) targets (#9479)

Fixes #9054
python · Sep 27, 2020 · 0b4a2c9 · 0b4a2c9
1 parent f668117
commit 0b4a2c9
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/mypy/checkexpr.py b/mypy/checkexpr.py
@@ -3788,6 +3788,9 @@ def accept(self,
         assert typ is not None
         self.chk.store_type(node, typ)
 
+        if isinstance(node, AssignmentExpr) and not has_uninhabited_component(typ):
+            self.chk.store_type(node.target, typ)
+
         if (self.chk.options.disallow_any_expr and
                 not always_allow_any and
                 not self.chk.is_stub and

diff --git a/test-data/unit/check-python38.test b/test-data/unit/check-python38.test
@@ -377,3 +377,13 @@ def check_partial_list() -> None:
         z.append(3)
     reveal_type(z)  # N: Revealed type is 'builtins.list[builtins.int]'
 [builtins fixtures/list.pyi]
+
+[case testWalrusExpr]
+def func() -> None:
+    foo = Foo()
+    if x := foo.x:
+        pass
+
+class Foo:
+    def __init__(self) -> None:
+        self.x = 123