Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace legacy API implementation with files() #221

Merged
merged 11 commits into from Jun 28, 2021
Merged

Replace legacy API implementation with files() #221

merged 11 commits into from Jun 28, 2021

Commits on May 29, 2021

  1. use files() API in contents() 

    Signed-off-by: Filipe Laíns <lains@riseup.net>
    @FFY00
    FFY00 committed May 29, 2021
    Configuration menu
    Copy the full SHA
    bd4d6ff View commit details
    Browse the repository at this point in the history

  2. _adapters: replace DegenerateFiles with CompatibilityFiles 

    Signed-off-by: Filipe Laíns <lains@riseup.net>
    @FFY00
    FFY00 committed May 29, 2021
    Configuration menu
    Copy the full SHA
    4ff68cf View commit details
    Browse the repository at this point in the history

  3. use files() api in open_* and read_* 

    Signed-off-by: Filipe Laíns <lains@riseup.net>
    @FFY00
    FFY00 committed May 29, 2021
    Configuration menu
    Copy the full SHA
    53fc1c6 View commit details
    Browse the repository at this point in the history

  4. use files() api in is_resource() 

    The files() api makes the identification of resources blury. Here we
re-implement is_resource() by mirroring the previous logic to the best
extent we can. This is not fully correct, as the files() api is not
fully compatible with the legacy api, but it is pretty close and as
correct as we can get. The semantics for what constitutes resources have
always been blurry in the first place.

Signed-off-by: Filipe Laíns <lains@riseup.net>
    @FFY00
    FFY00 committed May 29, 2021
    Configuration menu
    Copy the full SHA
    30cf1a9 View commit details
    Browse the repository at this point in the history

  5. compat: fix selecting the correct reader if the spec is None 

    Signed-off-by: Filipe Laíns <lains@riseup.net>
    @FFY00
    FFY00 committed May 29, 2021
    Configuration menu
    Copy the full SHA
    b1c38ab View commit details
    Browse the repository at this point in the history

  6. use files() api in path() 

    Signed-off-by: Filipe Laíns <lains@riseup.net>
    @FFY00
    FFY00 committed May 29, 2021
    Configuration menu
    Copy the full SHA
    62e905c View commit details
    Browse the repository at this point in the history

  7. remove _py3 implementation 

    Signed-off-by: Filipe Laíns <lains@riseup.net>
    @FFY00
    FFY00 committed May 29, 2021
    Configuration menu
    Copy the full SHA
    c2d85c9 View commit details
    Browse the repository at this point in the history

  8. common: ignore PermissionError in _tempfile 

    Signed-off-by: Filipe Laíns <lains@riseup.net>
    @FFY00
    FFY00 committed May 29, 2021
    Configuration menu
    Copy the full SHA
    5e8c1d2 View commit details
    Browse the repository at this point in the history

  9. tests: add tests for CompatibiltyFiles 

    Signed-off-by: Filipe Laíns <lains@riseup.net>
    @FFY00
    FFY00 committed May 29, 2021
    Configuration menu
    Copy the full SHA
    97083d2 View commit details
    Browse the repository at this point in the history

  10. tests: add test for CompatibilityFiles wrap_spec 

    Signed-off-by: Filipe Laíns <lains@riseup.net>
    @FFY00
    FFY00 committed May 29, 2021
    Configuration menu
    Copy the full SHA
    ef2f7c2 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2021

  1. legacy: move legacy API to separate module 

    Signed-off-by: Filipe Laíns <lains@riseup.net>
    @FFY00
    FFY00 committed Jun 26, 2021
    Configuration menu
    Copy the full SHA
    e016e66 View commit details
    Browse the repository at this point in the history