Merge pull request #274 from tirkarthi/fix-warnings

Fix ResourceWarning due to unclosed file resource.
python · Dec 6, 2022 · b14f9b5 · b14f9b5
2 parents d3f1e59 + 45edbc1
commit b14f9b5
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/CHANGES.rst b/CHANGES.rst
@@ -1,3 +1,8 @@
+v5.10.1
+=======
+
+* #274: Fixed ``ResourceWarning`` in ``_common``.
+
 v5.10.0
 =======
 

diff --git a/importlib_resources/_common.py b/importlib_resources/_common.py
@@ -203,5 +203,6 @@ def _write_contents(target, source):
         for item in source.iterdir():
             _write_contents(child, item)
     else:
-        child.open('wb').write(source.read_bytes())
+        with child.open('wb') as fp:
+            fp.write(source.read_bytes())
     return child