Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typing for load and select #483

Merged
merged 4 commits into from Mar 7, 2024

Conversation

Danyal-Faheem
Copy link
Contributor

Changes

  • Added typing for the Entrypoint.load() and the Entrypoints.select() method.

As the Entrypoint.load() returns more than one type depending on the value of the value variable, it was necessary to set it as Any.

Copy link
Member

@jaraco jaraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this change introduces a couple of new errors:

________________________ importlib_metadata/__init__.py ________________________
184: error: Item "None" of "Optional[Match[str]]" has no attribute "group"  [union-attr]
185: error: Item "None" of "Optional[Match[str]]" has no attribute "group"  [union-attr]

@jaraco jaraco merged commit 26b22b8 into python:main Mar 7, 2024
14 checks passed
@Danyal-Faheem Danyal-Faheem deleted the add-types-for-untyped-methods branch March 7, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants