Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the interface for SimplePath #480

Merged
merged 5 commits into from Dec 16, 2023
Merged

Conversation

jaraco
Copy link
Member

@jaraco jaraco commented Dec 16, 2023

While reviewing the interface for Distribution, I realized that locate_file was incorrectly reporting a return of pathlib.Path when it in fact could be a zipfile.Path or other SimplePath. This change expands the definition of SimplePath and then applies it to Distribution.locate_file and PackagePath.

  • Corrected the interface for SimplePath to encompass the expectations of locate_file and PackagePath.

@jaraco jaraco mentioned this pull request Dec 16, 2023
@jaraco jaraco merged commit 200cf45 into main Dec 16, 2023
28 checks passed
@jaraco jaraco deleted the bugfix/distribution-simplepath branch December 16, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant