Filter excess entries #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jaraco
commented
Mar 25, 2023
jaraco
commented
- Mark test as xfail as it's about to fail. Ref metadata directories appearing in packages_distributions #442.
- Add test capturing missed expectation. Ref metadata directories appearing in packages_distributions #442.
- 👹 Feed the hobgoblins (delint).
- Prefer all when asserting all.
- Filter non-identifiers from module names. Fixes metadata directories appearing in packages_distributions #442.
jaraco
force-pushed
the
bugfix/442-excess-entries
branch
from
f9dd164
to
da87042
Compare
pep8 states that comments should be limited to 72 characters.
⚫ Fade to black.
jaraco
force-pushed
the
bugfix/442-excess-entries
branch
from
da87042
to
340cac3
Compare
jaraco
commented
Mar 25, 2023
…ers.
The main contstraint here for an importable module is that it must not contain a module separator ('.'). Other names that contain dashes or spaces cannot be imported with the 'import' statement, but can be imported with 'importlib.import_module' or invoked with 'runpy'.
…onor that expectation.
…p-level names. Ref #442.
Captures new failed expectation and verifies fix.
|
Releasing as v6.2.1. |
jaraco
added a commit
to jherland/importlib_metadata
that referenced
this pull request
Apr 9, 2023
…port names" This reverts commit 70ff991. This behavior was adopted in 5e8260c and subsequently adapted as part of python#443.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.