Remove SelectableGroups deprecation exception for flake8. #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsibley
added a commit
to nextstrain/cli
that referenced
this pull request
Aug 13, 2021
…rtlib_metadata
The warning was turned into an error by our pytest config, and thus
resulted in test failures.
importlib_metadata used to specially suppress this deprecation warning
for flake8, but that special-casing was removed in June without any
update to flake8's to avoid the warning. See
python/importlib_metadata#319
and the flake8 PRs it links to for more background.
tsibley
added a commit
to nextstrain/cli
that referenced
this pull request
Aug 13, 2021
…rtlib_metadata
The warning was turned into an error by our pytest config, and thus
resulted in test failures.
importlib_metadata used to specially suppress this deprecation warning
for flake8, but that special-casing was removed in June without any
update to flake8's to avoid the warning. See
python/importlib_metadata#319
and the flake8 PRs it links to for more background.
jaraco
referenced
this pull request
in PyCQA/flake8
Nov 28, 2021
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #298 released with 3.6, this package introduced the
EntryPointsobjects with aSelectableGroupsshim for compatibility with older usages. During the review, asottile, the maintainer of flake8 informed me that flake8 has a slow release cadence and that it would be disruptive to suddenly expose a DeprecationWarning in flake8, especially since some users of flake8 will have-Werrorenabled.In merge request 464 and merge request 472, I made attempts to update flake8 to transition to the new interface. Since both attempts were dismissed rapidly and without guidance on how to proceed and without response to my plea for conversation, I see no option but to press forward with the deprecation.
@asottile Is there anything you'd like to do before the deprecation is introduced for flake8 as it has for other projects?