Update konoha upper bound #2778
Conversation
You can find the list of changes in konoha 5.0 here: https://github.com/himkt/konoha/releases/tag/v5.0.0 None of them affect flair. (In general, I recommend against potentially unnecessary pins in libraries. The reason I'm here is actually because konoha in turn had an unnecessary pin of another library that we needed to update)
|
Hello @hauntsaninja thanks for updating this! Unfortunately it seems the update is breaking our unit tests. I think this may have something to do with some of the dependencies added between 4.0.0 and 5.0.0 (see himkt/konoha@v4.0.0...v5.0.0#diff-f53a023eedfa3fbf2925ec7dc76eecdc954ea94b7e47065393dbad519613dc89) and in particular the importlib-metadata dependency (see celery/kombu#1339 and deprecation info here) |
|
Yeah, looks like there's some controversy surrounding flake8 and importlib-metadata, e.g. python/importlib_metadata#319 PyCQA/flake8#1438 I'll see if I can get CI green, if not I'll abandon this :-) |
|
Adding a pin in requirements-dev.txt to keep flake8 happy seems to have worked! |
|
I would not cap the version from above unless there is a known issue that this fixes. My vote is for |
|
Hello @hauntsaninja, this is the author of konoha. Thank you so much for the patch of konoha upgrade. @alanakbik Now the CI looks green with the latest version of konoha (action. Do we still have some blocker for this? One possible concern is about Python3.6 (konoha won't work with py36 due to some dependency updates). But I found the installation already fails with the latest master branch w/py36 (action, simply runs CI with py36). If we can drop the support for py36 (or already dropped it), I think it's possible to upgrade the konoha version as well. |
|
This PR has conflicts now and I'm not interested in seeing it through. Was easier to delete flair from the codebase I was working on. |
|
@alanakbik If we can work on upgrading the package, please let me know. 🙏 I'll create a tracking issue or PR. |
You can find the list of changes in konoha 5.0 here:
https://github.com/himkt/konoha/releases/tag/v5.0.0
None of them appear to affect flair.
(In general, I recommend against potentially unnecessary pins in
libraries. The reason I'm here is actually because konoha in turn
had an unnecessary pin of another library that we needed to update)