Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-98741: Remove useless check_home usage from is_python_build usage (GH-98743) #98743

Merged

Conversation

henryiii
Copy link
Contributor

This argument does nothing but trigger a warning. Removed from internal usage.

Affects Python 3.11.0+.

See gh-98741.

This argument does nothing but trigger a warning. Removed from internal usage.

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@vsajip vsajip changed the title gh-98741: Remove useless check_home usage from is_python_build usage gh-98741: Remove useless check_home usage from is_python_build usage (GH-98743) Oct 26, 2022
@vsajip vsajip merged commit a508631 into python:main Oct 26, 2022
@henryiii
Copy link
Contributor Author

henryiii commented Oct 26, 2022

Is there something that needs to be done to backport to 3.11.x? (As in, do I need to make a backport PR manually or is there some sort of bot command to do it?)

@vsajip
Copy link
Member

vsajip commented Oct 26, 2022

There's an automatic way, I'll see to it - was waiting for the merge tests to complete.

@vsajip vsajip added the needs backport to 3.11 only security fixes label Oct 26, 2022
@miss-islington
Copy link
Contributor

Thanks @henryiii for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-bot
Copy link

GH-98746 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Oct 26, 2022
@henryiii
Copy link
Contributor Author

Okay, just was making sure there wasn't something I needed to do. Thanks!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 26, 2022
…usage (pythonGH-98743)

(cherry picked from commit a508631)

Co-authored-by: Henry Schreiner <HenrySchreinerIII@gmail.com>
vsajip pushed a commit that referenced this pull request Oct 26, 2022
… usage (GH-98743) (GH-98746)

Co-authored-by: Henry Schreiner <HenrySchreinerIII@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants