Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-44863: In TypedDict allow inherit from Generic and preserve bases #27663

Merged
merged 40 commits into from May 3, 2022
Merged

bpo-44863: In TypedDict allow inherit from Generic and preserve bases #27663

merged 40 commits into from May 3, 2022

Commits on Aug 7, 2021

  1. Allow TypedDict to inherit from Generic

    @sransara
    sransara committed Aug 7, 2021
    Copy the full SHA
    6cfdc5f View commit details
    Browse the repository at this point in the history

  2. TypedDict preserve MRO

    @sransara
    sransara committed Aug 7, 2021
    Copy the full SHA
    c022e44 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2021

  1. Fix base classes to be just generic and dict

    @sransara
    sransara committed Sep 3, 2021
    Copy the full SHA
    2fa00b8 View commit details
    Browse the repository at this point in the history

  2. Simplify addiotion of Generic base class

    @sransara
    sransara committed Sep 3, 2021
    Copy the full SHA
    b829d8a View commit details
    Browse the repository at this point in the history

  3. Fully proxy origin by using types.GenericAlias

    @sransara
    sransara committed Sep 3, 2021
    Copy the full SHA
    c5762df View commit details
    Browse the repository at this point in the history

  4. Add NEWS blurb

    @sransara
    sransara committed Sep 3, 2021
    Copy the full SHA
    4c5db0a View commit details
    Browse the repository at this point in the history

  5. Add better NEWS blurb

    @sransara
    sransara committed Sep 3, 2021
    Copy the full SHA
    34189dd View commit details
    Browse the repository at this point in the history

  6. Add more testcases

    @sransara
    sransara committed Sep 3, 2021
    Copy the full SHA
    0cfd637 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2021

  1. Add implicit any test case

    @sransara
    sransara committed Sep 4, 2021
    Copy the full SHA
    5e808af View commit details
    Browse the repository at this point in the history

  2. Fix issue with plain generic inheritance

    @sransara
    sransara committed Sep 4, 2021
    Copy the full SHA
    a2482ff View commit details
    Browse the repository at this point in the history

  3. Include bases assertion

    @sransara
    sransara committed Sep 4, 2021
    Copy the full SHA
    071c1b6 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2021

  1. Update NEWS blurb with better formatting 

    Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com>
    @sransara @Fidget-Spinner
    sransara and Fidget-Spinner committed Sep 5, 2021
    Copy the full SHA
    3ce517b View commit details
    Browse the repository at this point in the history

  2. Revert overriding of getitem and not proxy dunders

    @sransara
    sransara committed Sep 5, 2021
    Copy the full SHA
    2f003e0 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2021

  1. Use alternative way to find if Generic base is needed 

    Fixes issue described in: python#27663 (comment)

Co-authored-by: Yurii Karabas <1998uriyyo@gmail.com>
    @sransara @uriyyo
    sransara and uriyyo committed Sep 6, 2021
    Copy the full SHA
    964f7d3 View commit details
    Browse the repository at this point in the history

  2. Make it clear when Generic base is included

    @sransara
    sransara committed Sep 6, 2021
    Copy the full SHA
    c3c0e51 View commit details
    Browse the repository at this point in the history

  3. Add getitem:so TD is subscriptable only if Generic

    @sransara
    sransara committed Sep 6, 2021
    Copy the full SHA
    d34c99e View commit details
    Browse the repository at this point in the history

  4. Fix test consistency for empty params

    @sransara
    sransara committed Sep 6, 2021
    Copy the full SHA
    cea66c4 View commit details
    Browse the repository at this point in the history

  5. Test for adding new generic arg in child class

    @sransara
    sransara committed Sep 6, 2021
    Copy the full SHA
    0ed4326 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2022

  1. Update Lib/typing.py 

    Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
    @sransara @JelleZijlstra
    sransara and JelleZijlstra committed Apr 30, 2022
    Copy the full SHA
    b1fcd16 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into py-generic-typeddict-simple

    @serhiy-storchaka
    serhiy-storchaka committed Apr 30, 2022
    Copy the full SHA
    2905f29 View commit details
    Browse the repository at this point in the history

  3. Fix merge error.

    @serhiy-storchaka
    serhiy-storchaka committed Apr 30, 2022
    Copy the full SHA
    afa5e51 View commit details
    Browse the repository at this point in the history

  4. Fix trailing spaces.

    @serhiy-storchaka
    serhiy-storchaka committed Apr 30, 2022
    Copy the full SHA
    94138f6 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2022

  1. Merge branch 'main' into py-generic-typeddict-simple

    @serhiy-storchaka
    serhiy-storchaka committed May 1, 2022
    Copy the full SHA
    2572930 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2022

  1. Fix indentation

    @sransara
    sransara committed May 2, 2022
    Copy the full SHA
    c2e1d8d View commit details
    Browse the repository at this point in the history

  2. Remove trailing commas in tuples

    @sransara
    sransara committed May 2, 2022
    Copy the full SHA
    d3d9456 View commit details
    Browse the repository at this point in the history

  3. Add test with flipped bases

    @sransara
    sransara committed May 2, 2022
    Copy the full SHA
    311852c View commit details
    Browse the repository at this point in the history

  4. Move implicit any test to on its own case

    @sransara
    sransara committed May 2, 2022
    Copy the full SHA
    dc98753 View commit details
    Browse the repository at this point in the history

  5. Add checks for orig_bases and mro

    @sransara
    sransara committed May 2, 2022
    Copy the full SHA
    9bed1d4 View commit details
    Browse the repository at this point in the history

  6. Remove specialization from generic get_type_hints

    @sransara
    sransara committed May 2, 2022
    Copy the full SHA
    6c152e7 View commit details
    Browse the repository at this point in the history

  7. Check type hints of inherited generic typeddict

    @sransara
    sransara committed May 2, 2022
    Copy the full SHA
    f88201b View commit details
    Browse the repository at this point in the history

  8. Remove unused statement

    @sransara
    sransara committed May 2, 2022
    Copy the full SHA
    6ea95df View commit details
    Browse the repository at this point in the history

  9. Add class method through the metaclass

    @sransara
    sransara committed May 2, 2022
    Copy the full SHA
    80e9104 View commit details
    Browse the repository at this point in the history

  10. Fix generic base when inherited from implicit any

    @sransara
    sransara committed May 2, 2022
    Copy the full SHA
    dbbb707 View commit details
    Browse the repository at this point in the history

  11. Fix whitespacing with reindent.py

    @sransara
    sransara committed May 2, 2022
    Copy the full SHA
    56b69e0 View commit details
    Browse the repository at this point in the history

  12. fix tuple

    @JelleZijlstra
    JelleZijlstra committed May 2, 2022
    Copy the full SHA
    4a40825 View commit details
    Browse the repository at this point in the history

  13. remove unnecessary __class_getitem__ override

    @JelleZijlstra
    JelleZijlstra committed May 2, 2022
    Copy the full SHA
    4b50ae2 View commit details
    Browse the repository at this point in the history

  14. Merge remote-tracking branch 'upstream/main' into py-generic-typeddic… 

    …t-simple
    @JelleZijlstra
    JelleZijlstra committed May 2, 2022
    Copy the full SHA
    ecc7726 View commit details
    Browse the repository at this point in the history

  15. docs

    @JelleZijlstra
    JelleZijlstra committed May 2, 2022
    Copy the full SHA
    5b5a983 View commit details
    Browse the repository at this point in the history

  16. Merge branch 'main' into py-generic-typeddict-simple

    @JelleZijlstra
    JelleZijlstra committed May 2, 2022
    Copy the full SHA
    99a1430 View commit details
    Browse the repository at this point in the history

  17. Merge branch 'main' into py-generic-typeddict-simple

    @JelleZijlstra
    JelleZijlstra committed May 2, 2022
    Copy the full SHA
    79c2bb4 View commit details
    Browse the repository at this point in the history