bpo-40747: Make py_version_nodot 3_10 not 310 (PEP 641) #22858
Conversation
…into mattip-py_version_nodot
zooba
requested review from
brettcannon,
encukou,
ericsnowcurrently,
ncoghlan,
warsaw and
a team
as code owners
| @@ -269,11 +269,11 @@ Py_NO_ENABLE_SHARED to find out. Also support MS_NO_COREDLL for b/w compat */ | |||
| file in their Makefile (other compilers are | |||
| generally taken care of by distutils.) */ | |||
| # if defined(_DEBUG) | |||
| # pragma comment(lib,"python3_10_d.lib") | |||
| # pragma comment(lib,"python3.10_d.lib") | |||
There was a problem hiding this comment.
Wouldn’t it be better to consistently use _ everywhere? Then no one has to think which to use.
There was a problem hiding this comment.
Other platforms already use dots in the equivalent filename. We decided on consistency there (though if I can't fix the crashes, we may roll back this part entirely and just change packaging stuff).
There was a problem hiding this comment.
LGTM (I guess 😄)
Nothing jumped out at me after a quick read through the changes. However, I am not very familiar with this stuff. (Presumably you've exercised all this by hand and it works.) Also, I haven't checked for anything in the code base you might have missed (but am not sure what I'd look for).
If you can find someone more familiar with this stuff you might want another opinion before merging. 😄
|
Thanks Eric! There's still a PEP to approve, which will attract more eyes I'm sure (plus a discussion at the sprints about whether it's worth changing everything away from "310" or not). |
|
It seems not all instances of |
|
@encukou I honestly don't think the |
What is the proposed tag for v31.0 then? There are a number of other names that qualify as an implementation detail, so we should be consistent about updating all or none. Another alternative to this whole patch is to just override the wheel tag generation code (wherever that is...), rather than changing any of the internal variables at all. |
|
@zooba generic interpreter tag version calculation: |
…atibility tag Regardless of the py_version_nodot variable. See https://www.python.org/dev/peps/pep-0641/ See python/cpython#22858 (comment)
|
…atibility tag Regardless of the py_version_nodot variable. See https://www.python.org/dev/peps/pep-0641/ See python/cpython#22858 (comment)
…atibility tag Regardless of the py_version_nodot variable. See https://www.python.org/dev/peps/pep-0641/ See python/cpython#22858 (comment)
|
The PEP has been rejected. |
Implement PEP 641, and fixes pypa/packaging#308, pypa/wheel#354, and maybe pypa/pip#8312. The current value of
310is ambiguous so use3_10or3.10as appropriate.Also cleans up some woefully out-of-date documentation.
Co-authored-by: mattip matti.picus@gmail.com
https://bugs.python.org/issue40747