New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-39082: Fix: AsyncMock is unable to correctly patch static/class methods #17717
Conversation
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
I think this implementation is good, I am wondering if @tirkarthi's suggestion of:
wouldn't be better, as it might cover more use cases. It might have the potential of helping out with the backwards compatibility issue with 3.6 in testing-cabal/mock#476. What do you think Karthikeyan? |
@czardoz - please can you add a NEWS entry for this? |
I would prefer accessing function from |
@czardoz - can you add a NEWS entry for this please, I'd like to merge it :-) |
Wrong way round, closing this in favour of #18116. |
@tirkarthi - I think I'm fine with the |
I was just concerned if I was missing any other internals having |
Essentially, patching a coroutinefunction decorated with
@classmethod
or@staticmethod
does not currently work correctly. Instead of creating anAsyncMock()
,patch()
uses aMock()
, which fails when it's awaited on.https://bugs.python.org/issue39082