bpo-26967: fix flag grouping with allow_abbrev=False #14316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `allow_abbrev` option for ArgumentParser is documented and intended to disable support for unique prefixes of --options, which may sometimes be ambiguous due to deferred parsing. However, the initial implementation also broke parsing of grouped short flags, such as `-ab` meaning `-a -b`. Checking for a leading `--` fixes this.
|
/cc @bethard |
mangrisano
approved these changes
Jun 23, 2019
blueyed
approved these changes
Jul 2, 2019
|
Thank you for taking care of the issue. |
encukou
reviewed
Jul 13, 2019
| @@ -182,6 +182,10 @@ ArgumentParser objects | |||
| .. versionchanged:: 3.5 | |||
| *allow_abbrev* parameter was added. | |||
|
|
|||
| .. versionchanged:: 3.8 | |||
There was a problem hiding this comment.
Suggested change
| .. versionchanged:: 3.8 | |
| .. versionchanged:: 3.9 |
There was a problem hiding this comment.
I'm still hoping that this will be merged into the 3.8 branch before 3.8.0, but I guess we can adjust the number later.
|
I talked to a more experienced core dev, and we agreed that this a bugfix appropriate for 3.8. |
|
No worries! I'm just glad I can make a contribution, and getting it into 3.8 is even better 😄 |
encukou
approved these changes
Jul 14, 2019
|
Thanks @Zac-HD for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 14, 2019
The `allow_abbrev` option for ArgumentParser is documented and intended to disable support for unique prefixes of --options, which may sometimes be ambiguous due to deferred parsing. However, the initial implementation also broke parsing of grouped short flags, such as `-ab` meaning `-a -b` (or `-a=b`). Checking the argument for a leading `--` before rejecting it fixes this. This was prompted by pytest-dev/pytestGH-5469, so a backport to at least 3.8 would be great 😄 And this is my first PR to CPython, so please let me know if I've missed anything! https://bugs.python.org/issue26967 (cherry picked from commit dffca9e) Co-authored-by: Zac Hatfield-Dodds <Zac-HD@users.noreply.github.com>
|
GH-14759 is a backport of this pull request to the 3.8 branch. |
encukou
pushed a commit
that referenced
this pull request
Jul 14, 2019
…4759) The `allow_abbrev` option for ArgumentParser is documented and intended to disable support for unique prefixes of --options, which may sometimes be ambiguous due to deferred parsing. However, the initial implementation also broke parsing of grouped short flags, such as `-ab` meaning `-a -b` (or `-a=b`). Checking the argument for a leading `--` before rejecting it fixes this. This was prompted by pytest-dev/pytestGH-5469, so a backport to at least 3.8 would be great 😄 And this is my first PR to CPython, so please let me know if I've missed anything! https://bugs.python.org/issue26967 (cherry picked from commit dffca9e) Co-authored-by: Zac Hatfield-Dodds <Zac-HD@users.noreply.github.com>
lisroach
pushed a commit
to lisroach/cpython
that referenced
this pull request
Sep 10, 2019
The `allow_abbrev` option for ArgumentParser is documented and intended to disable support for unique prefixes of --options, which may sometimes be ambiguous due to deferred parsing. However, the initial implementation also broke parsing of grouped short flags, such as `-ab` meaning `-a -b` (or `-a=b`). Checking the argument for a leading `--` before rejecting it fixes this. This was prompted by pytest-dev/pytest#5469, so a backport to at least 3.8 would be great 😄 And this is my first PR to CPython, so please let me know if I've missed anything! https://bugs.python.org/issue26967
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
The `allow_abbrev` option for ArgumentParser is documented and intended to disable support for unique prefixes of --options, which may sometimes be ambiguous due to deferred parsing. However, the initial implementation also broke parsing of grouped short flags, such as `-ab` meaning `-a -b` (or `-a=b`). Checking the argument for a leading `--` before rejecting it fixes this. This was prompted by pytest-dev/pytest#5469, so a backport to at least 3.8 would be great 😄 And this is my first PR to CPython, so please let me know if I've missed anything! https://bugs.python.org/issue26967
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
allow_abbrevoption for ArgumentParser is documented and intended to disable support for unique prefixes of --options, which may sometimes be ambiguous due to deferred parsing.However, the initial implementation also broke parsing of grouped short flags, such as
-abmeaning-a -b(or-a=b). Checking the argument for a leading--before rejecting it fixes this.This was prompted by pytest-dev/pytest#5469, so a backport to at least 3.8 would be great 😄
And this is my first PR to CPython, so please let me know if I've missed anything!
https://bugs.python.org/issue26967