Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-36675: Fix doctest directives comments disappear bug #13125

Closed
wants to merge 2 commits into from

Conversation

tczorro
Copy link

@tczorro tczorro commented May 6, 2019

  1. Change :: detective to : in order to fix the doc bugs
    ref:https://bugs.python.org/issue36675

https://bugs.python.org/issue36675

1. Change :: detective to : in order to fix the doc bugs
ref:https://bugs.python.org/issue36675
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels May 6, 2019
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

Copy link

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tczorro
Copy link
Author

tczorro commented Aug 25, 2019

@JulienPalard I am sorry to bother you, but if you have some spare time, could you please review this little patch for doc fix.

@JulienPalard
Copy link
Member

I tried a local build and your patch do not fix the issue. I'm investigating, I just found a trim_doctest_flags variable in tools/extensions/pyspecific.py, probably a good lead.

@JulienPalard
Copy link
Member

I opened an issue here: sphinx-doc/sphinx#6698 and commented on b.p.o.

As this PR proposes a fix that does not fix the issue (the flags are still trimmed), I'll just close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting core review docs Documentation in the Doc dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants