Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix version number in use_load_tests deprecation reference #119151

Merged
merged 1 commit into from
May 22, 2024
Merged

Fix version number in use_load_tests deprecation reference #119151

merged 1 commit into from
May 22, 2024

Conversation

jacobtylerwalls
Copy link
Contributor

@jacobtylerwalls jacobtylerwalls commented May 18, 2024 •
edited by github-actions bot

Deprecation took place in d78742a (3.5)

📚 Documentation preview 📚: https://cpython-previews--119151.org.readthedocs.build/

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news awaiting review labels May 18, 2024
blaisep
blaisep reviewed May 20, 2024
View reviewed changes
Copy link
Contributor

@blaisep blaisep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch,
...there is a directive called .. deprecated:: which might be useful here.

Doc/whatsnew/3.12.rst
@@ -1739,7 +1739,7 @@ unittest

* Undocumented :meth:`TestLoader.loadTestsFromModule
<unittest.TestLoader.loadTestsFromModule>` parameter *use_load_tests*
(deprecated and ignored since Python 3.2).
(deprecated and ignored since Python 3.5).
Copy link
Contributor

@blaisep blaisep May 20, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch thank you.
Could you put this in a .. deprecated:: 3.5 directive ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking a look. I only see uses of that directive in the actual documentation relating to the method itself, not here in the changelog. I'm reluctant to add the first such directive in this /whatsnew directory.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough. I guess this may be impacted by the bigger topic mentioned in #109843 (comment) having to do with moving deprecation and removal items out of news.

Doc/whatsnew/3.12.rst
@@ -1739,7 +1739,7 @@ unittest

* Undocumented :meth:`TestLoader.loadTestsFromModule
<unittest.TestLoader.loadTestsFromModule>` parameter *use_load_tests*
(deprecated and ignored since Python 3.2).
(deprecated and ignored since Python 3.5).

* An alias of the :class:`~unittest.TextTestResult` class:
``_TextTestResult`` (deprecated in Python 3.2).
Copy link
Contributor

@blaisep blaisep May 20, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might also be a candidate for ..deprecated :: 3.2

serhiy-storchaka
serhiy-storchaka approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@serhiy-storchaka serhiy-storchaka added skip issue needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels May 22, 2024
@serhiy-storchaka serhiy-storchaka merged commit aee8f03 into python:main May 22, 2024
34 checks passed
@miss-islington-app
Copy link

Thanks @jacobtylerwalls for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 22, 2024
@jacobtylerwalls @miss-islington
Fix version number in use_load_tests deprecation reference (pythonGH-…
f89fc31 
…119151)

Deprecation took place in d78742a (3.5)
(cherry picked from commit aee8f03)

Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 22, 2024
@jacobtylerwalls @miss-islington
Fix version number in use_load_tests deprecation reference (pythonGH-…
34bd528 
…119151)

Deprecation took place in d78742a (3.5)
(cherry picked from commit aee8f03)

Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented May 22, 2024

GH-119386 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 22, 2024
@bedevere-app
Copy link

bedevere-app bot commented May 22, 2024

GH-119387 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label May 22, 2024
serhiy-storchaka pushed a commit that referenced this pull request May 22, 2024
@miss-islington @jacobtylerwalls
[3.12] Fix version number in use_load_tests deprecation reference (GH…
2c7e9de 
…-119151) (GH-119387)

Deprecation took place in d78742a (3.5)
(cherry picked from commit aee8f03)

Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
serhiy-storchaka pushed a commit that referenced this pull request May 22, 2024
@miss-islington @jacobtylerwalls
[3.13] Fix version number in use_load_tests deprecation reference (GH…
414346e 
…-119151) (GH-119386)

Deprecation took place in d78742a (3.5)
(cherry picked from commit aee8f03)

Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
@jacobtylerwalls jacobtylerwalls deleted the fix-deprecation-reference branch May 22, 2024 10:14
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blaisep blaisep blaisep left review comments

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jacobtylerwalls @blaisep @serhiy-storchaka