Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-110383: Document socket.makefile() accepts combined modes #119150

Merged
merged 4 commits into from
May 21, 2024

Conversation

squeakyboots
Copy link
Contributor

@squeakyboots squeakyboots commented May 18, 2024

Copy link

cpython-cla-bot bot commented May 18, 2024

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news awaiting review labels May 18, 2024
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change the docstring in Lib/socket.py as well, so they are synchronised?

Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@erlend-aasland erlend-aasland added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels May 21, 2024
@erlend-aasland erlend-aasland enabled auto-merge (squash) May 21, 2024 16:05
@erlend-aasland erlend-aasland merged commit 62a29be into python:main May 21, 2024
37 checks passed
@miss-islington-app

This comment was marked as outdated.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 21, 2024
…ythonGH-119150)

The supported mode values are 'r', 'w', and 'b', or a combination of those.
(cherry picked from commit 62a29be)

Co-authored-by: Daniel Williams <dann0a@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 21, 2024
…ythonGH-119150)

The supported mode values are 'r', 'w', and 'b', or a combination of those.
(cherry picked from commit 62a29be)

Co-authored-by: Daniel Williams <dann0a@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented May 21, 2024

GH-119324 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 21, 2024
@bedevere-app
Copy link

bedevere-app bot commented May 21, 2024

GH-119325 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label May 21, 2024
erlend-aasland pushed a commit that referenced this pull request May 21, 2024
…GH-119150) (#119324)

The supported mode values are 'r', 'w', and 'b', or a combination of those.
(cherry picked from commit 62a29be)

Co-authored-by: Daniel Williams <dann0a@gmail.com>
erlend-aasland pushed a commit that referenced this pull request May 21, 2024
…GH-119150) (#119325)

The supported mode values are 'r', 'w', and 'b', or a combination of those.
(cherry picked from commit 62a29be)

Co-authored-by: Daniel Williams <dann0a@gmail.com>
@squeakyboots squeakyboots deleted the socket.makefile-doc-modes branch May 22, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants