-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize CI #574
Modernize CI #574
Conversation
Bump versions, remove unused lines, test Python 3.11.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only had one nit.
if-no-files-found: error | ||
|
||
coverage: | ||
if: always() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Is this if
necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! I even plan to add it to urllib3 if you agree. This ensures that the coverage step runs even if some jobs failed (but still waiting for everything to finish).
In urllib3 sometimes one single job fails because of a flaky test and we have no idea if coverage is still at 100% or not. The test suite will still be failing, but that way we don't need to wait for everything to pass to know if coverage is still at 100%. It will also cover the case when as admins we just merge a change even if unrelated tests are failing: we have merged uncovered code in the past like that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooooo I love that!! TIL! Thanks Quentin!
To unblock #563, this pull request does three main things:
I wished I did not have to do everything at once but the codecov uploader was removed, forcing our hand.