New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop Python 2 support #346
Conversation
Codecov Report
@@ Coverage Diff @@
## master #346 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 1186 1169 -17
Branches 47 46 -1
=========================================
- Hits 1186 1169 -17
|
ffa92eb
to
a325e38
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for tackling this! The type annotations are much better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Can you please add a news fragment?
I added a news fragment. |
Thanks! I had difficulties updating the required checks from my phone, hence the delay. |
As discussed in #341, this drops Python 2 support. There's not big advantage to it, just makes the code a bit nicer (the typing in particular).