Fix setuptools 50 import in Python 3.6.1 pylint test #1706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1706 +/- ##
=======================================
Coverage 99.61% 99.61%
=======================================
Files 115 115
Lines 14445 14445
Branches 1106 1106
=======================================
Hits 14389 14389
Misses 41 41
Partials 15 15 |
altendky
approved these changes
Aug 31, 2020
There was a problem hiding this comment.
Fun... Looks to fit the use case they encourage this for.
https://setuptools.readthedocs.io/en/latest/history.html?highlight=SETUPTOOLS_USE_DISTUTILS#v50-0-0
|
Yeah. The good news is that this is specific to 3.6.1, for all other Pythons we can use the setuptools version! Thanks for the review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/pypa/setuptools/issues/2350 for details. pip, setuptools and wheel are the only packages that we don't pin, and indeed the pylint tests started failing with setuptools 50.0 on Python 3.6.1. (No other configuration is affected.)