Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trio.tests import causing warnings #135

Merged
merged 2 commits into from Sep 3, 2023

Conversation

VincentVanlaer
Copy link
Member

It is deprecated and the replacement is made private as trio._tests. While we could be using that, this commit copies over the one relevant function that is actually necessary. The other two imports just repeat tests that are already in trio and do not need repeating here.

It is deprecated and the replacement is made private as trio._tests.
While we could be using that, this commit copies over the one relevant
function that is actually necessary. The other two imports just repeat
tests that are already in trio and do not need repeating here.
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me.

@pquentin pquentin merged commit e930e6f into python-trio:master Sep 3, 2023
21 checks passed
@VincentVanlaer VincentVanlaer deleted the fix-tests branch September 3, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants