This repository has been archived by the owner on Apr 14, 2022. It is now read-only.
Updated setup.py to make it build with python 3.7. #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! The build is going to fail because we don't have urllib3/urllib3#1457 yet, so I'll add Python 3.7 to the build matrix later. The changes look good, thanks, but can you restore the comment? You can also fix the typo: Remove -> Removing while you're at it. |
|
Yeah sure I will do that |
pquentin
suggested changes
Oct 22, 2018
pquentin
approved these changes
Oct 22, 2018
|
Thank you @RatanShreshtha for your contribution! Merged. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.