Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add testing dimension for flake8=5 and flake8=6, add py311 #68

Merged
merged 2 commits into from Nov 26, 2022

Conversation

jakkdl
Copy link
Member

@jakkdl jakkdl commented Nov 25, 2022

fixes #65
also adds support for py311, and rejigs a bunch of the configs. Took inspiration from black's tox.ini, and got the filterwarnings from hypothesis.

crossing my fingers that the CI supports 3.11 in an easy way such as this.
Not sure this needs an entry in the changelog?
Also, looking at setup.py - did you forget to change the author_email when creating it? That sure looks like .. not your email.

@Zac-HD
Copy link
Member

Zac-HD commented Nov 26, 2022

Looks great - I don't think this needs a changelog entry (end-users don't need to care), and will fix the email address (oops).

The filterwarnings spec... sent me down a rabbithole, HypothesisWorks/hypothesis#3514 and Zac-HD/hypothesmith#24. Will update, push, and merge later this evening.

@Zac-HD Zac-HD merged commit 8809f2a into python-trio:main Nov 26, 2022
@jakkdl
Copy link
Member Author

jakkdl commented Nov 29, 2022

Wow, pretty nasty to miss a rename - glad that got resolved! And good cleanups ✨

@jakkdl jakkdl deleted the flake8_6 branch November 29, 2022 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

install_require flake8>=6.0?
2 participants