Add new rules to ruff config #4250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bibo-Joshi
reviewed
May 10, 2024
| @@ -165,7 +165,7 @@ class SimpleUpdateProcessor(BaseUpdateProcessor): | |||
|
|
|||
| async def do_process_update( | |||
| self, | |||
| update: object, | |||
| update: object, # noqa: ARG002 | |||
There was a problem hiding this comment.
tbh this seems like a bug in ARG002 - is the parent class defines this, ruff shouldn't complain …
There was a problem hiding this comment.
I'll open an issue on their repo and see what they think
There was a problem hiding this comment.
I'd still be okay with merging btw
apparently pre-commit does not run on rebasing
Bibo-Joshi
approved these changes
May 12, 2024
|
all done from my side. Can be merged |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most notably adds the "ARG" rule which I deliberately didn't add previously. #4180 (comment) prompted this.