Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API 7.3 Chat Backgrounds and new params #4247

Merged
merged 13 commits into from May 11, 2024

Conversation

aelkheir
Copy link
Contributor

@aelkheir aelkheir commented May 9, 2024

Closes #4236

Describe the solution you'd like

Check-list for PRs

  • Added .. versionadded:: NEXT.VERSION, .. versionchanged:: NEXT.VERSION or .. deprecated:: NEXT.VERSION to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit test
  • Documented code changes according to the CSI standard <https://standards.mousepawmedia.com/en/stable/csi.html>__
  • Added myself alphabetically to AUTHORS.rst (optional)
  • Added new classes & modules to the docs and all suitable __all__ s
  • Checked the Stability Policy <https://docs.python-telegram-bot.org/stability_policy.html>_ in case of deprecations or changes to documented behavior

If the PR contains API changes (otherwise, you can ignore this passage)

Checked the Bot API

  • specific sections of the Stability Policy <https://docs.python-telegram-bot.org/stability_policy.html>_
  • Created a PR to remove functionality deprecated in the previous Bot API release (see here <https://docs.python-telegram-bot.org/en/stable/stability_policy.html#case-2>_)
  • New classes:
    • Added self._id_attrs and corresponding documentation
    • __init__ accepts api_kwargs as kw-only
  • Added new shortcuts:
    • In :class:~telegram.Chat & :class:~telegram.User for all methods that accept chat/user_id
    • In :class:~telegram.Message for all methods that accept chat_id and message_id
    • For new :class:~telegram.Message shortcuts: Added quote argument if methods accepts reply_to_message_id
    • In :class:~telegram.CallbackQuery for all methods that accept either chat_id and message_id or inline_message_id
  • If relevant:
    • Added new constants at :mod:telegram.constants and shortcuts to them as class variables
    • Link new and existing constants in docstrings instead of hard-coded numbers and strings
    • Add new message types to :attr:telegram.Message.effective_attachment
    • Added new handlers for new update types
    • Add the handlers to the warning loop in the :class:~telegram.ext.ConversationHandler
    • Added new filters for new message (sub)types
    • Added or updated documentation for the changed class(es) and/or method(s)
    • Added the new method(s) to _extbot.py
    • Added or updated bot_methods.rst
    • Updated the Bot API version number in all places: README.rst and README_RAW.rst (including the badge), as well as telegram.constants.BOT_API_VERSION_INFO
    • Added logic for arbitrary callback data in :class:telegram.ext.ExtBot for new methods that either accept a reply_markup in some form or have a return type that is/contains :class:~telegram.Message

- [x] Added the field via_join_request to the class ChatMemberUpdated.
- [x] Added the parameter live_period to the method editMessageLiveLocation.
- [x] Added the classes `ChatBackground`, `BackgroundType`, `BackgroundFill` and the
field `chat_background_set` of type `ChatBackground` to the class Message,
describing service messages about background changes
@Bibo-Joshi Bibo-Joshi mentioned this pull request May 9, 2024
12 tasks
Copy link
Member

@Bibo-Joshi Bibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the nice PR! I've added a few comments

telegram/_bot.py Outdated Show resolved Hide resolved
telegram/_chatbackground.py Show resolved Hide resolved
telegram/constants.py Outdated Show resolved Hide resolved
telegram/constants.py Outdated Show resolved Hide resolved
telegram/_chatbackground.py Outdated Show resolved Hide resolved
telegram/_chatbackground.py Outdated Show resolved Hide resolved
telegram/_chatbackground.py Outdated Show resolved Hide resolved
telegram/_chatbackground.py Outdated Show resolved Hide resolved
telegram/_chatbackground.py Show resolved Hide resolved
telegram/_message.py Show resolved Hide resolved
@aelkheir
Copy link
Contributor Author

Thanks for reviewing! Addressed comments.

@Bibo-Joshi Bibo-Joshi mentioned this pull request May 10, 2024
Copy link
Member

@Bibo-Joshi Bibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fast updates - just one new comment :)

telegram/constants.py Outdated Show resolved Hide resolved
@Bibo-Joshi Bibo-Joshi merged commit ad8da9a into python-telegram-bot:api-7.3-central May 11, 2024
16 of 22 checks passed
@Bibo-Joshi
Copy link
Member

Thank you very much for the helpful PR 👏

@aelkheir aelkheir deleted the api-7.3 branch May 11, 2024 14:40
@github-actions github-actions bot locked and limited conversation to collaborators May 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants