Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Job.__lt__ #3432

Merged
merged 1 commit into from Dec 19, 2022
Merged

Drop Job.__lt__ #3432

merged 1 commit into from Dec 19, 2022

Conversation

Bibo-Joshi
Copy link
Member

@Bibo-Joshi Bibo-Joshi commented Dec 19, 2022

as discussed in the dev chat

Was removed since its use case is unknown, is misleading since you may think it compared something, when it actually did not. Was also undocumented, hence non-breaking

Checklist for PRs

  • [ ] Added .. versionadded:: version, .. versionchanged:: version or .. deprecated:: version to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests
  • [ ] Documented code changes according to the CSI standard
  • [ ] Added myself alphabetically to AUTHORS.rst (optional)
  • [ ] Added new classes & modules to the docs and all suitable __all__ s

@harshil21 harshil21 added this to the v20.0 milestone Dec 19, 2022
@Bibo-Joshi Bibo-Joshi merged commit 5b629ed into master Dec 19, 2022
@Bibo-Joshi Bibo-Joshi deleted the non-orderable-jobs branch December 19, 2022 17:32
clot27 added a commit that referenced this pull request Dec 21, 2022
clot27 added a commit that referenced this pull request Dec 21, 2022
clot27 added a commit that referenced this pull request Dec 21, 2022
clot27 added a commit that referenced this pull request Dec 21, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants